godot icon indicating copy to clipboard operation
godot copied to clipboard

Add a way to know when a TileMapLayer's cell is modified [v2]

Open Khusheete opened this issue 1 year ago • 2 comments

Hi !

This PR adds a callback inside the TileMapLayer that gets called when cells are updated. This was discussed in godotengine/godot#96078, which was a previous attempt at implementing this feature.

Khusheete avatar Aug 27 '24 21:08 Khusheete

For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.

akien-mga avatar Aug 27 '24 22:08 akien-mga

This has been pending for over a month can we have someone look at this that can move this forward? @Khusheete @groud

I made a similar PR as well because I had difficulty finding this PR https://github.com/godotengine/godot/pull/97896 I would be happy with any implementation

jeffbdavenport avatar Oct 06 '24 19:10 jeffbdavenport

The checks on macOS have failed and I am not sure why. This PR may need a rebase, preferably squashing the commits, and then it's very good to merge.

Mickeon avatar Oct 26 '24 11:10 Mickeon

It needs a rebase indeed

AThousandShips avatar Oct 26 '24 11:10 AThousandShips

Oops, I think I messed up the rebase.

Khusheete avatar Oct 26 '24 14:10 Khusheete

Oops, I think I messed up the rebase.

Ok, I fixed it !

Khusheete avatar Oct 26 '24 15:10 Khusheete

Force pushed an amend to fix the commit message which was mangled, and properly fix author credits.

akien-mga avatar Nov 11 '24 12:11 akien-mga

Thanks! Congratulations on your first contribution! 🎉

Repiteo avatar Nov 11 '24 20:11 Repiteo