godotengine
Add separate timeline snapping control to Animation Editor
This adds a separate toggle for timeline snapping (disabled by default as per @Calinou 's suggestion in the proposal) Closes https://github.com/godotengine/godot-proposals/issues/10225
https://github.com/user-attachments/assets/c47602cf-9735-4361-a326-3bdecc312914
Both can still be toggled by holding Ctrl/Command
Note I changed the _get_editor_step() function to no longer check for whether snapping was enabled as it was already done before the function call in the _seek_value_changed function. Then I added a check the _animation_key_editor_seek function as well.
It's feedback, but the icons and descriptions are unclear. Although I think it's fine for the function :)
With SnapTimeline and SnapKey, there is a misconception that it snaps to the grid of the timeline and the keys of other tracks (like smart grid); we need to avoid confusing it with such as the "grid snap" and "point snap" in Draw software / DCC software.
So more thought needs to be given to icons. It may be exaggerated to use Enum and explain it in text, but at least the description should be something like "Apply snapping to current time/key", not "Snap Timeline".
Thought:
@TokageItLab yeah good point. I'll improve the description. I quite like your icons idea... I'll fire up Inkscape and see what I can do!
Redesigned the icons and improved the descriptions and renamed a few things.
https://github.com/user-attachments/assets/ad41b47c-9b16-4a1d-a4b5-8f6ff8403e23
I'm not sure if that timeline snap icon reads well. it kind of looks like a taller version of the filter icon with a magnet next to it.
Sorry @TokageItLab , forgot to update that as I had to do a few and thought it was just the merge conflict on this one. Should be updated now as suggested.
