godot icon indicating copy to clipboard operation
godot copied to clipboard

Add method for getting packet flags from ENetPacketPeer

Open Chaosed0 opened this issue 1 year ago • 3 comments

Fixes proposal 10240: https://github.com/godotengine/godot-proposals/issues/10240

This PR adds the get_packet_flags method to ENetPacketPeer which can be used to obtain the flags sent with the packet. In my experimentation, it appears that not all flags are replicated from peer to peer, but it's unclear which are and which aren't (the ENet documentation does not specify), so I opted not to include this info explicitly in Godot's documentation.

This is my first PR, so let me know if I have missed anything.

Chaosed0 avatar Aug 06 '24 21:08 Chaosed0

For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.

akien-mga avatar Oct 01 '24 13:10 akien-mga

Thanks for the heads up. I've rebased all the commits onto the latest master branch and updated all my commits to be the correct author. Hopefully that is the right way to resolve things.

Chaosed0 avatar Oct 01 '24 18:10 Chaosed0

It seems good, yes!

The final step for our PR workflow would be to squash the commits together. See this page for instructions.

I can also do it myself before merging tomorrow. Edit: Done.

akien-mga avatar Oct 01 '24 23:10 akien-mga

Thanks! And congrats for your first merged Godot contribution :tada:

akien-mga avatar Oct 02 '24 13:10 akien-mga