godotengine
Fix graph node sizing regression, improve blend tree contrast/margins
Improved light theme contrast and readability by adding some margins and adjusting some theme stuff that I think might be leftovers from previous PRs that made adjustments to this.
Fixed graph nodes using get_size() instead of get_minimum_size() when they weren't resizable which could result in the nodes retaining their original size after changes. I could not find what exactly caused this regression since 4.2 but this seems like it should be the intended behavior anyhow, if the user can't resize the graph node, it should just adjust to its contents automatically.
| 4.2 | 4.3 | This PR |
|---|---|---|
In which cases does the regression appear? Could you upload an minimal reproduction project?
I'll try to make an MRP this weekend to check under what circumstances it happens, the only one that was clear was when opening and closing the resource picker in StateMachine nodes in blend trees.
I'm not sure if it's something specific to this particular node (EditorResourceProperty) interacting with the graph node so I'll do some more digging
I've done some testing, and I don't think the issue comes from the graph node itself, but rather something else that's not allowing the resize to trigger and make the node recalculate its size.
For this particular specific case I've removed the minimum size change and added a fix that restores the original behavior in the blend trees graph, since I haven't seen anything else affected by this I think this is the path with the least friction, if slightly hacky
I updated the PR title and description to reflect that. But do you still have the minimum size patch around?
Rebased, and I can confirm the embedded inspector is broken now, unrelated to the PR
This PR fixes a problem that I recently noticed in my theme where progress bars with expanded margins wouldn't even fit within the nodes
I had to remove expanded margins because of that, making all of the progress bars in the editor smaller. When this PR is merged I can make progress bars bigger again
