godot icon indicating copy to clipboard operation
godot copied to clipboard

Fix `EditorInterface.get_selected_paths()` working incorrectly when FileSystemDock is in split mode

Open fstxz opened this issue 1 year ago • 5 comments

Fixes #88228

fstxz avatar Jul 24 '24 16:07 fstxz

Will try and test this tomorrow

AThousandShips avatar Jul 24 '24 16:07 AThousandShips

I wonder if folders that are selected in the tree should also be included when in split mode? Otherwise you can't select multiple folders that are in different places without changing the display mode to tree only.

fstxz avatar Jul 25 '24 12:07 fstxz

In split mode if you have a folder selected, but none of the files, the returned list is empty. If no file is selected, maybe the selected directory should be returned at least?

KoBeWi avatar Aug 17 '24 13:08 KoBeWi

@KoBeWi I updated the PR, I hope this is what you meant.

fstxz avatar Aug 17 '24 15:08 fstxz

Seems like it's possible to multi-select in tree in split view

It's also possible to deselect everything with ctrl, this is why I chose to return ony the current directory.

fstxz avatar Aug 17 '24 16:08 fstxz

Thanks! And congrats for your first merged Godot contribution :tada:

akien-mga avatar Aug 19 '24 12:08 akien-mga

Cherry-picked for 4.3.1.

akien-mga avatar Sep 16 '24 15:09 akien-mga