godot icon indicating copy to clipboard operation
godot copied to clipboard

Add occlusion enabled option to TileMapLayer

Open sorascode opened this issue 1 year ago • 6 comments

Partially Addreses

  • https://github.com/godotengine/godot-proposals/issues/10121

Now light occlusion can be enabled/disabled per TileMapLayer

sorascode avatar Jul 05 '24 11:07 sorascode

Hi, thanks for the contribution. While the change is not that much code, the TileMap node is deprecated. IMHO, unless there's really high demand for it, I would rather avoid new features there.

groud avatar Jul 05 '24 11:07 groud

@groud Hi, I exposed the occlusion enabled property in the TileMapLayer node now :) Do you think we can get this merged if I remove the changes in the TileMap node again?

sorascode avatar Jul 05 '24 12:07 sorascode

We are in feature freeze so this won't make the cut in 4.3, at earliest in 4.4.

Also do not forget to squash your commits! See the pull request workflow.

Mickeon avatar Jul 05 '24 12:07 Mickeon

Do you think we can get this merged if I remove the changes in the TileMap node again?

Yeah, I think it would be good to merge without the changes to the TileMap (in 4.4 though, as, like Mickeon said, we are in feature-freeze for 4.3 now).

groud avatar Jul 05 '24 13:07 groud

We can always add the changes to TileMap separately if they are desired, along with the collision enable which

AThousandShips avatar Jul 05 '24 13:07 AThousandShips

Alright, thanks for the feedback, the TileMap changes have been removed!

sorascode avatar Jul 05 '24 13:07 sorascode

Thanks! And congrats for your first merged Godot contribution :tada:

akien-mga avatar Aug 27 '24 22:08 akien-mga

I've been looking all around for the function/code to turn off the occlusion of a tilemap layer and can't find it anywhere. Could I get an example of how to do this?

SueHeir avatar Oct 08 '24 23:10 SueHeir

It's in 4.4 only

KoBeWi avatar Oct 09 '24 06:10 KoBeWi