godot icon indicating copy to clipboard operation
godot copied to clipboard

Color Picker eyedropper tool selects Node instead of picking color

Open bogcow opened this issue 1 year ago • 1 comments

Tested versions

4.3.beta2

System information

Windows 10

Issue description

https://github.com/godotengine/godot/assets/157412753/c51c5838-9fb5-40e0-8f18-e904d461cc80

In the video, I try to use the eyedropper tool of the ColorPicker, but whenever I select the red color (which is a ColorRect), instead of properly changing the color, the red ColorRect is selected instead. This behavior seems much more consistent when you are on single window mode, but it also occurs when you are not on single window mode as well.

Steps to reproduce

  • Download the sample project
  • Change editor settings to enable single window mode
  • Try to change the modulate property of the white ColorRect by using the color picker eyedropper onto the red area

Minimal reproduction project (MRP)

Test.zip

bogcow avatar Jun 28 '24 20:06 bogcow

Bisecting points to #74962 as the culprit:

image


I also tried to reproduce the issue without --single-window but wasn't able to replicate.

matheusmdx avatar Jun 29 '24 00:06 matheusmdx

Still reproducible in 4.3-rc1

cjmaxik avatar Jul 29 '24 09:07 cjmaxik

CC @KoBeWi

akien-mga avatar Jul 29 '24 09:07 akien-mga

It's worse than that. When another node gets selected, the color change is not stored in undo history.

EDIT: The issue is caused by inconsistency between single-window and multi-window modes. In single-window mode, clicking outside popup will pass the event further, instead of ignoring it.

KoBeWi avatar Jul 29 '24 12:07 KoBeWi