godot icon indicating copy to clipboard operation
godot copied to clipboard

Resolve conflict between shader uniform tooltips `/**` and general annotation `/**/`.

Open magian1127 opened this issue 9 months ago • 2 comments

see https://github.com/godotengine/godot/issues/91547#issuecomment-2093992570

fix #91547

magian1127 avatar May 04 '24 04:05 magian1127

What happens if someone uses:

/**
 * Some description.
 */

with no space (but only end of line, $) on the first line?

IMO this should be supported so you might need to support any whitespace (space, tab) or end of line.

Or alternatively, match /**[^/] instead.

akien-mga avatar May 13 '24 15:05 akien-mga

This PR has been modified again to solve the following 2 problems.

1 Change the regular to \*\*\s start match, to solve the problem of lagging. 2 Add a color_region of /**/ to solve the region interrupt problem. (This is still a stopgap measure, and it would be better to rewrite _get_line_syntax_highlighting_impl .)

magian1127 avatar May 14 '24 07:05 magian1127

Thanks!

akien-mga avatar May 17 '24 09:05 akien-mga