Fix no reparent after hover and no move.
Fixes #91254
I'm not sure why this was setting selected while it is not selecting it but just putting a mark. The only thing I could see as difference is wether the node is selected at the end of the drag or not so I postponed the selection to the end of the drag. I think my modification made so that set_selected actually do the modification to the EditorSelection which make sense but unvoluntarily this was relying on the broken behavior of it not making the modification.
Edit : forgot to push
- Bugsquad exit, see also: https://github.com/godotengine/godot/pull/91430
I tested this PR and everything seems to work fine. My only concern is that I don't think the "hover" node should be selected after a drag&drop. The standard in UI is that after a drag&drop the moved nodes are selected.
Some exemples: https://github.com/godotengine/godot/assets/81109165/153c56a3-5638-4bd6-a556-896055fa03c7
https://github.com/godotengine/godot/assets/81109165/4af85808-0bef-4e96-b017-750f9a86b733
Yep, if you reparent node, the dropped node should be selected.
Is this still needed after #91265, or fully superseded by that PR?
Probably not, as the issue is fully resolved.