godot icon indicating copy to clipboard operation
godot copied to clipboard

C#: Ignore late bound methods in MustBeVariantAnalyzer

Open raulsntos opened this issue 9 months ago • 3 comments

If symbol is late bound (as is the case when using dynamic) we can't obtain the symbol to analyze the usage of [MustBeVariant].

  • Fixes https://github.com/godotengine/godot/issues/91345.

raulsntos avatar Apr 30 '24 17:04 raulsntos

Is this safe (and worth it) to cherry-pick for 4.2?

akien-mga avatar Apr 30 '24 19:04 akien-mga

It's safe but will likely not cherry-pick cleanly because of surrounding changes. I don't think it's worth cherry-picking though since dynamic is pretty much discouraged these days.

raulsntos avatar Apr 30 '24 19:04 raulsntos

Maybe adding a test, to prevent future regressions 👀

paulloz avatar Apr 30 '24 20:04 paulloz

Thanks!

akien-mga avatar May 01 '24 07:05 akien-mga