godot
godot copied to clipboard
[4.2] Headless import leads to invalid geometry in GDQuest TPS demo
Tested versions
- Reproducible in 4.2.2.stable, 4.2.1.stable, 4.2.stable
- Not reproducible in 4.3.dev (64520fe6741d8ec3c55e0c9618d3fadcda949f63), so it's 4.2 specific, but backporting the fix would be great
System information
Fedora Linux 40 (KDE Plasma) - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX 7600M XT (RADV NAVI33) () - AMD Ryzen 7 7840HS w/ Radeon 780M Graphics (16 Threads)
Issue description
When importing the GDQuest TPS demo (https://github.com/gdquest-demos/godot-4-3d-third-person-controller) with 4.2.2.stable in --headless
mode (godot --import --headless -v
), the tree meshes seem to be broken:
Import logs: import-headless.log
When importing without --headless
, the trees are correct (godot --import -v
):
Import logs: import-vulkan.log
The main difference between the import logs is this error:
ERROR: Parameter "m" is null.
at: mesh_get_surface_count (servers/rendering/dummy/storage/mesh_storage.h:114)
Steps to reproduce
- Clone https://github.com/gdquest-demos/godot-4-3d-third-person-controller
- Import with
godot --headless --import
(or in earlier 4.2.x verisons,godot --headless -e --quit-after 100
) - Run the project
Minimal reproduction project (MRP)
I'll see if I can extract a scene, but for now it's just: https://github.com/gdquest-demos/godot-4-3d-third-person-controller
I just tested and confirmed that cherrypicking https://github.com/godotengine/godot/pull/88210 fixes this issue (actually what I did was revert https://github.com/godotengine/godot/pull/88210 and confirm that doing so introduces the issue into master)
Is all the steps completed to close this? Do we need to cherry pick?
I will cherrypick the PR.