godotengine
Restrict Vulkan and D3D12 project settings to editor or when disabled
This PR only defines Vulkan and D3D12 project settings in editor or when matched ones enabled.
This PR integrates these custom_prop_infos from D3D12 into matching GLOBAL_DEFs, probably an oversight.
What problem is this solving?
For D3D12 and/or Vulkan enabled builds, these are required to function properly and, for editor, so for those want to tweak whatever they want. With disabled, it will not apply the default values, thus reduces a bit more of an binary size.
Normally we prefer all settings to be defined for all platforms but set off, so I am confused.
This would reduce binary size by a tiny bit, not really worth it on its own, especially with the issues of it affecting usability with the settings, is there any other reason to hide them? If not I don't think this makes sense
In terms of UX, one issue if you disable certain settings at compile-time is that if you open a project that has modified these settings, the settings will be considered as custom settings (like obsolete settings that were removed in 4.0).
--doctool output will also differ based on the build-time options used.
One question, should i make "integrate custom_prop_infos into GLOBAL_DEFs" as a seperate PR?