godot icon indicating copy to clipboard operation
godot copied to clipboard

Improve some notification and translation docs

Open KoBeWi opened this issue 11 months ago • 4 comments

Closes #89804

KoBeWi avatar Mar 23 '24 16:03 KoBeWi

~Before this is merged, I would like to tackle a way that makes the current behavior people use to update texts still work.~

See below.

YeldhamDev avatar Mar 23 '24 17:03 YeldhamDev

On the NOTIFICATION_TRANSLATION_CHANGED doc also mention it gets sent when setting auto translate mode. It seems like a important thing and I kind of forgot about that. When creating the issue, I thought it only gets sent when changing locale or smth (as I have never had a reason to set the auto translate mode at runtime).

Kiisu-Master avatar Mar 23 '24 21:03 Kiisu-Master

I thought it only gets sent when changing locale or smth

The current naming definitely doesn't help. We discussed in the dev chat that also the opportunity arrives, to replace _CHANGED with _UPDATED.

Also, I'm afraid that people will have to adapt to the new way of doing it. As I can't think of a way to support the old behavior without over-complicating things.

YeldhamDev avatar Mar 23 '24 21:03 YeldhamDev

On the NOTIFICATION_TRANSLATION_CHANGED doc also mention it gets sent when setting auto translate mode.

Done.

KoBeWi avatar Mar 24 '24 14:03 KoBeWi

Thanks!

akien-mga avatar Mar 25 '24 09:03 akien-mga