godot icon indicating copy to clipboard operation
godot copied to clipboard

Move server files into their subfolders

Open aaronfranke opened this issue 1 year ago • 2 comments

This PR moves most of the servers/*.{cpp,h} files into the subfolders, when they exist. The old approach always seemed off to me. If there is a folder for a thing, we should put all files for that thing in the folder.

This PR also improves consistency, as some servers (debugger, extensions, and movie writer) did not have any top-level files. Note that this PR does not introduce any new folders.

aaronfranke avatar Mar 12 '24 04:03 aaronfranke

This feels like a good call. But I don't about every server being in its own folder. Physic servers greatly benefit from it due of the other Godot Physics files, though.

Mickeon avatar Mar 16 '24 12:03 Mickeon

Hmmm, I have mixed feelings about this. The thing that was really nice about having the exposed API classes in the root was that there was a easy to recognise difference between the outward facing servers, and their internal implementation. This kind of looses that separation.

At the same time, I'm not a fan of having everything in one folder and wonder if there isn't some middle ground here.

BastiaanOlij avatar Mar 25 '24 04:03 BastiaanOlij

~Is there a reason for rasterizer_dummy.h having its own subfolder? It's the only dummy file organized like that, and the subfolder only contains that single file.~

Misread the git diff, ignore that. :stuck_out_tongue:

YeldhamDev avatar Mar 31 '25 02:03 YeldhamDev

Thanks!

Repiteo avatar Oct 03 '25 17:10 Repiteo