godot icon indicating copy to clipboard operation
godot copied to clipboard

Fix Skeleton3D insert key tooltips

Open skyace65 opened this issue 1 year ago • 5 comments

Original text looks like it was written by someone in the middle of a stroke. This PR fixes that. Closes https://github.com/godotengine/godot-docs/issues/8957

skyace65 avatar Feb 16 '24 02:02 skyace65

Does the button only key rotations, or also translations? If it's only rotations, that button was even more severely mislabeled than I originally thought

hunterbk avatar Feb 16 '24 05:02 hunterbk

@fire both buttons only work for rotation, I tested that before making this PR. If they're intended to keyframe position and scale as well that's currently broken in 4.2.1. Here's a video of me using the buttons. Button Test.zip

skyace65 avatar Feb 16 '24 12:02 skyace65

In your video the button for rotation was selected, did you try selecting the other buttons (next to it).

image

fire avatar Feb 16 '24 18:02 fire

You were right Fire, I completely forgot about those buttons. I've updated this PR but I'd like to re-word it further tomorrow. I want to try and keep the description consistent with what we use for the key button in the toolbar for 2D scenes.

skyace65 avatar Feb 17 '24 04:02 skyace65

Updated description again, ready for review again.

skyace65 avatar Feb 18 '24 15:02 skyace65

Needs rebase.

Edit: Rebased myself.

akien-mga avatar Jul 29 '24 12:07 akien-mga

Thanks!

akien-mga avatar Jul 30 '24 10:07 akien-mga