godot icon indicating copy to clipboard operation
godot copied to clipboard

Published 20 hours ago • verified publisher icon godotengine

Fix crash when there is no bones to rename when retargeting an imported skeleton

Open ydeltastar opened this issue 1 year ago • 2 comments

Fixes https://github.com/godotengine/godot/issues/88086

ydeltastar avatar Feb 08 '24 17:02 ydeltastar

Wonder if #87905 would also fix this.

tdaven avatar Feb 08 '24 18:02 tdaven

@tdaven Tested it and it does fix the issue.

ydeltastar avatar Feb 08 '24 20:02 ydeltastar

Does the other pr supersede this one?

fire avatar Feb 09 '24 01:02 fire

I think so since this only works when the map is empty where the other PR prevents bad lookups on a const HashMap with '[]' which purposely crashes but I was going to leave that decision up to a reviewer.

tdaven avatar Feb 09 '24 06:02 tdaven

https://github.com/godotengine/godot/pull/87905 supersedes this according to tdaven. Will archive this pull request this in a bit unless there's other opinions.

fire avatar Feb 09 '24 08:02 fire

Sounds good to me. Anything as long as retargeting is working.

ydeltastar avatar Feb 09 '24 12:02 ydeltastar

Crash fixed with the merging of https://github.com/godotengine/godot/pull/81746

ydeltastar avatar Apr 26 '24 23:04 ydeltastar