godotengine
Fix texture artifacts around Sprite3D with linear filtering
Closes https://github.com/godotengine/godot/issues/73739
This PR fully fixes the original issue described, by disabling the texture repeat on the material generated by Sprite3D, preventing the color to leak around the edges outright.
| Before | After |
|---|---|
This issue also exists in Label3D, but you'd never ever see it in practice, as it resizes with a bit of padding around the edges to compensate.
Bugsquad edit: Fixes https://github.com/godotengine/godot/issues/82044
Interesting. This PR started with that very same new bool property, but then I realised how useless it would be in practice and scaled it back to always be false.
Interesting. This PR started with that very same new bool property, but then I realised how useless it would be in practice and scaled it back to always be
false.
I guess we should verify that it can actually be used. This comment says that users can tile sprites by setting the region property
No, I do believe it. In hindsight it makes sense and can actually be used that way. My assumption was wrong.
Regardless of the way it is done, I'm not sure about it being the "default" as suggested. The repeating texture repeating issues around the border is not obvious.
No, I do believe it. In hindsight it makes sense and can actually be used that way. My assumption was wrong.
Regardless of the way it is done, I'm not sure about it being the "default" as suggested. The repeating texture repeating issues around the border is not obvious.
I agree. I think repeat could be an option, but shouldn't be the default
@clayjohn Is this PR intended to replace #82193? It seems like #82193 already provides an option to enable/disable sprite texture wrapping as discussed previously.
No, I do believe it. In hindsight it makes sense and can actually be used that way. My assumption was wrong.
Regardless of the way it is done, I'm not sure about it being the "default" as suggested. The repeating texture repeating issues around the border is not obvious.
I agree. I think repeat could be an option, but shouldn't be the default
In my Pull Request(#82193) it's already by default disabled. I thought its most of the cases a bug then a feature and people who wanna use it most likely find how to enable it.
Is there something others (me, maybe) can do to help this PR move forward?
Is there something others (me, maybe) can do to help this PR move forward?
It needs a decision from the rendering team on whether this approach is preferred, or exposing the repeat option like done in #82193 or #90202. So one thing you can do is check all three PRs and bring them up for decision making in a rendering team meeting.
Is there something others (me, maybe) can do to help this PR move forward?
It needs a decision from the rendering team on whether this approach is preferred, or exposing the repeat option like done in #82193 or #90202. So one thing you can do is check all three PRs and bring them up for decision making in a rendering team meeting.
The rendering team discussed this in March and explained how it should be implemented here: https://github.com/godotengine/godot/pull/82193#issuecomment-1996597424
Um, so I happen to need this too in my game. Is anyone still working on it, or is it up for grabs?
