godot icon indicating copy to clipboard operation
godot copied to clipboard
verified publisher icon godotengine

Fix negative light rendering in global illumination

Open Calinou opened this issue 2 years ago • 2 comments

Negative lights no longer emit positive indirect light.

This affects VoxelGI, SDFGI and LightmapGI.

Testing project: test_light_negative.zip

Preview

All lights have Indirect Energy set to 10, and the yellow light on the left has its Negative property enabled.

VoxelGI

Before After (this PR)
Screenshot_20240109_184429 Screenshot_20240109_185218

LightmapGI

Before After (this PR)
Screenshot_20240104_201430 Screenshot_20240104_201118

SDFGI

Before After (this PR)
Screenshot_20240104_201513 Screenshot_20240104_201353

Calinou avatar Jan 04 '24 19:01 Calinou

In the first comparison, why did the white light to the right side of the wall suddenly get so much brighter with the PR?

Ansraer avatar Jan 04 '24 23:01 Ansraer

In the first comparison, why did the white light to the right side of the wall suddenly get so much brighter with the PR?

This appears to be due to different properties being used between screenshots. I've retested the PR on latest master and have updated the VoxelGI screenshots accordingly, brightness is now similar :slightly_smiling_face:

Calinou avatar Jan 09 '24 17:01 Calinou