godot icon indicating copy to clipboard operation
godot copied to clipboard

Reimport file when .import changes

Open KoBeWi opened this issue 1 year ago • 1 comments

Fixes #60730

Editor was already detecting that .import file has changed, but _test_for_reimport() which triggers the actual reimport did not check that.

Might need some testing.

KoBeWi avatar Nov 16 '23 13:11 KoBeWi

@KoBeWi , thanks for looking into this!

I was unaware of your attempt, and created https://github.com/godotengine/godot/pull/85067 (for 3.x).

The approaches are certainly different: here the fix is about the modification time of files.

Mine is more potentially disruptive (modifies the format of the .md5 files in the .import folder), but seems to work, too.

There's also the possibility that the fixes need to be different for each major version, due to different root causes.

turbohz avatar Nov 18 '23 19:11 turbohz

As we're reworking FS import stuff with #92303, might be worth including this too. I'd suggest waiting for #92303 to be merge, then rebase and make sure it works and we can include it too.

akien-mga avatar Jun 26 '24 11:06 akien-mga

As we're reworking FS import stuff with #92303, might be worth including this too. I'd suggest waiting for #92303 to be merge, then rebase and make sure it works and we can include it too.

Can be rebased and re-tested now.

akien-mga avatar Jun 29 '24 17:06 akien-mga

Rebased and still works.

KoBeWi avatar Jun 29 '24 18:06 KoBeWi

Thanks!

akien-mga avatar Jul 08 '24 17:07 akien-mga