godot icon indicating copy to clipboard operation
godot copied to clipboard

Add editor setting to make tab always indent the line

Open jmdejong opened this issue 1 year ago • 5 comments

See https://github.com/godotengine/godot-proposals/issues/7816

This add a setting to always make the tab key indent the current line in a code editor

godot_editor_settings_tab_action_description2

  • Bugsquad edit, closes: https://github.com/godotengine/godot-proposals/issues/7816

jmdejong avatar Sep 23 '23 17:09 jmdejong

If anyone can thing of better naming and description please let me know.

There should probably also be tests for this behaviour, but I'm not sure whether it would be better to expand the existing tests or to add new tests.

jmdejong avatar Sep 23 '23 17:09 jmdejong

I think it would be better to document that using the enum style, as in each option has its own line for clarity:

image

mieldepoche avatar Sep 24 '23 07:09 mieldepoche

I like how it looks in enum style. The specific way it's done in your example is not use anywhere else in edtor_settings.xml, so I made a multiline description that matches the other dropdown editor settings more godot_editor_settings_tab_action_description

jmdejong avatar Sep 24 '23 08:09 jmdejong

I just thought of it now, but I'd personally rename "Advance" to "Insert". It's what it does, as stated in the doc string.

Also, this sentence should have a . at the end (idk how to suggest changes in github, or if I even can) image

mieldepoche avatar Sep 24 '23 12:09 mieldepoche

Makes sense. I changed it

jmdejong avatar Sep 25 '23 18:09 jmdejong