godot
godot copied to clipboard
godotengine
Prevent project manager from deleting files when removing projects
Fixes #74678
This is a quick fix for the immediate problem. The project manager doesn't provide the option to move the directory contents to the trash anymore. I also added some words making it clear that nothing will be deleted. The larger issue of the projet manager UX probably requires a separate proposal.
As an aside: I think the sentence "The project folders' contents won't be modified." could be replaced with something more to the point, like "This will not delete any files." May be worth discussing.
I think it should be kept as "not modified" and "not deleted" are very different
Also the commit message sounds more like it is fixing that it doesn't delete the files, could be confusing for future maintenance, maybe "Prevent project manager from deleting files..."
I think it should be kept as "not modified" and "not deleted" are very different
True, although I'd argue deletion is a subset of modification. My point was more that people in that situation probably care about the "deletion" part more than about the "modifcation" part, so a different wording might give them more peace of mind.
Also the commit message sounds more like it is fixing that it doesn't delete the files, could be confusing for future maintenance, maybe "Prevent project manager from deleting files..."
Fair enough, I see how this makes it less ambiguous.
I think this is a useful option that should not be removed. Instead, we can prevent the Project Manager from treating an unrelated directory as a project. I think if we forbid creating projects in non-empty folders, then this should solve both problems.
If we keep this option, we should still improve its UX to make sure that what is going to be deleted is extremely clear to the user.
It should show very clearly the path to the folder which is going to be deleted.
I don't have strong feelings either way, as I've never been bitten by this, so I'm fine with either. It sounds to me that the solution with the most support behind it would be to
- Disallow project creation in non-empty folders
- Allow deleting files when removing projects from project manager
- Highlight the directory that is about to be deleted
Let's keep this discussion to one place, it gets harder and harder to follow when each of you double-posts your thoughts in both the issue and this PR :) As far as I understand, this PR was only meant as an implementation of the proposed solution, so let's keep the discussion to the issue where that proposal was made.
Closing this, as the preferred solution likely involves a different approach.