godot icon indicating copy to clipboard operation
godot copied to clipboard

Converter 3 -> 4: Replaces all connect() functions although not signal

Open Reneator opened this issue 2 years ago • 1 comments

Godot version

v4.0.stable.official [92bee43ad]

System information

Windows 10

Issue description

In my project i have a function name called "get_or_connect" which also had 3 arguments, where the Conversion then put the last 2 args inside of a callable, bricking the method.

Here it seems that it has a regex like "connect(" and if that would be expanded to ".connect(" this kinds of false replacements could be prevented.

Steps to reproduce

Open the MRP and open it with godot 4 and convert it to godot 4.

Now there should be a lot of renames in the one Script "Main.gd" which are incorrect. You can check the script before the conversion to check or see in the comments

Minimal reproduction project

Reproduction connect replacement.zip

Reneator avatar Mar 09 '23 09:03 Reneator

Here it seems that it has a regex like "connect(" and if that would be expanded to ".connect(" this kinds of false replacements could be prevented.

It should match both .connect( and connect( standalone (so preceded by space or tab in practice). But indeed that should be doable with a simple tweak to the regex.

akien-mga avatar Mar 09 '23 09:03 akien-mga