godot icon indicating copy to clipboard operation
godot copied to clipboard

[4.0] Project converter: Missing conversion for class properties extending InputEventWithModifiers

Open nobuyukinyuu opened this issue 2 years ago • 0 comments

Godot version

4.0 stable

System information

Windows 10

Issue description

With code in virtual funcs like _gui_input(event), qualifying event should hint to the project converter in a specified code block to allow renaming of members that have changed names from 3.x to 4.x.

Examples include (but not limited to):

  • shift -> shift_pressed
  • control -> control_pressed (see note)
  • alt -> alt_pressed

Note: I don't know the default remapping behavior under 3.x but if the intent is to remap ctrl/command depending on OS, project migration should probably warn user in some way (either annotate line with comment or if migration warnings are planned, add one)

Similar to other issues like #67003 where type inference qualification needs to be done to be confident with replacement

Steps to reproduce

Migrate 3.5 project to 4.0

Minimal reproduction project

n/a

nobuyukinyuu avatar Mar 05 '23 01:03 nobuyukinyuu