godot icon indicating copy to clipboard operation
godot copied to clipboard

Published 20 hours ago • verified publisher icon godotengine

Fix comparison

Open mjunix opened this issue 1 year ago • 2 comments

mjunix avatar Mar 03 '23 22:03 mjunix

Could you elaborate? What does this do? What issue does this fix?

Mickeon avatar Mar 05 '23 13:03 Mickeon

The fix seems correct, but indeed the commit message and PR title should be made more explicit about what this does. For example, "macOS export: Fix validation of codesigning certificate password".

You can modify the commit message by amending the commit, and force pushing the changes, so that it stays as a single commit (see PR workflow).

akien-mga avatar Mar 05 '23 16:03 akien-mga

Also agree with @akien-mga this looks fine barring the commit message. If you no longer want to update this PR do let us know and we can sort out the fix. :+1:

lawnjelly avatar Mar 23 '23 09:03 lawnjelly

Thanks!

akien-mga avatar Apr 11 '23 17:04 akien-mga

Cherry-picked for 4.0.3.

YuriSizov avatar Apr 24 '23 14:04 YuriSizov