godot Fix unable to disconnect signal in Editor once created

Fixes https://github.com/godotengine/godot/issues/69348.

https://github.com/godotengine/godot/pull/66665's implementation was a bit too stupid and didn't account all cases. Most importantly, signals that had yet to be saved.

Do note the result of this function still isn't cached. It probably could and should be, but this is just about fixing this nuisance.

There is still a bug with this implementation. That is, a sub-scene's direct signals are considered to be editable, which they should not. It's possible I may be able to fix it efficiently in this PR, but it's still better than the current nuisance.

Dec 06 '22 13:12 Mickeon

Seems like this PR makes it possible to disconnect foreign connections again...

Dec 06 '22 16:12 KoBeWi

Alright, back to work.

Dec 06 '22 16:12 Mickeon

Thanks!

Dec 09 '22 06:12 akien-mga

Seems like discarding instancing (using the Make Local option) doesn't remove the flag and the connections cannot be disconnected at all.

EDIT: Yep, the flag is incorrectly stored in the local scene. There is no way to remove it other than manually editing the tscn file. I'll open an issue I guess.

Apr 07 '23 22:04 KoBeWi