godot icon indicating copy to clipboard operation
godot copied to clipboard

Fix Sprite drag and drop hint mentions invalid option with root node selected

Open nongvantinh opened this issue 1 year ago • 4 comments

Fixes #69219

Fix the incorrect hint when dragging and dropping assets into the scene while the root node is selected.

nongvantinh avatar Nov 28 '22 10:11 nongvantinh

This breaks translation, I believe you need to include the TTR calls to each line that includes a part of the string.

RedMser avatar Nov 28 '22 12:11 RedMser

I was not familiar with TTR; thanks for the suggestion and explanations.

nongvantinh avatar Nov 28 '22 13:11 nongvantinh

Looks good! Could you squash the commits? See PR workflow for instructions.

akien-mga avatar Nov 28 '22 13:11 akien-mga

Sorry for only noticing it now, could you also amend the commit message to be more explicit? The current commit doesn't really give much context so it's hard to make sense of taken individually. What I used to change the PR title could be a good description for the commit too.

akien-mga avatar Nov 28 '22 13:11 akien-mga

@akien-mga Tested and ready to merge 👍

coppolaemilio avatar Dec 12 '22 11:12 coppolaemilio

Thanks!

akien-mga avatar Dec 12 '22 11:12 akien-mga

https://gist.github.com/angstyloop/08200c6d816347c82ea1aed56c219f17

angstyloop avatar Jan 22 '23 10:01 angstyloop