godot icon indicating copy to clipboard operation
godot copied to clipboard

Published 20 hours ago • verified publisher icon godotengine

Standardize and optimize icon SVG

Open AndreVallestero opened this issue 3 years ago • 9 comments

Optimize icon.svg and base derivative icons on the same SVG path

Resulting optimization:

  • icon.svg 7,722B -> 797B
  • project_icon.svg 3,773B -> 849B
  • DefaultProjectIcon.svg 4,173B -> 921B

Note, DefaultProjectIcon's 128x128 base dimensions are preserved. The other two icons should be resized as needed, so no default dimension was set.

AndreVallestero avatar Nov 13 '22 06:11 AndreVallestero

I really don't like how "icon.svg" looks here. If the intent was to make it follow the aspects of the other icon, I think that one should be modified instead.

YeldhamDev avatar Nov 13 '22 12:11 YeldhamDev

@YeldhamDev it's funny that you mention that, since icon.svg is the reference so the new version is pretty much identical. Here's a side-by-side: image

AndreVallestero avatar Nov 13 '22 13:11 AndreVallestero

I'm talking about the paddings in the "DefaultProjectIcon.svg" icon.

YeldhamDev avatar Nov 13 '22 13:11 YeldhamDev

Why did the face color change? Before #478cbf, after #4488cc. The color is part of Godot's branding and shouldn't be changed.

Edit: You also seem to have changed the eye color (also part of the branding) and the project icon background color (doesn't matter as much, but it's another arbitrary change without documented motivation).

akien-mga avatar Nov 13 '22 14:11 akien-mga

e4b662c reverts the 12bit color optimization and the padding change noted by @YeldhamDev

AndreVallestero avatar Nov 13 '22 16:11 AndreVallestero

@YeldhamDev @akien-mga is there anything blocking this PR from getting approved?

AndreVallestero avatar Mar 07 '23 23:03 AndreVallestero

@AndreVallestero Are the file size numbers in the OP up-to-date? Can you show before/after images?

aaronfranke avatar Mar 07 '23 23:03 aaronfranke

icon.svg 7,722B -> 804B project_icon.svg 3,773B -> 907B DefaultProjectIcon.svg 4,173B -> 911B

Before and after images can be previewed here: https://github.com/godotengine/godot/pull/68598/files

AndreVallestero avatar Mar 08 '23 01:03 AndreVallestero

I would also make viewBox match the fixed height and width on all three of the images. Other than that, it looks fine.

YuriSizov avatar Mar 08 '23 10:03 YuriSizov

@MewPurPur You can probably pick up the torch and finish this PR, keeping the original author as a co-author :) It's been quite some time since my feedback.

YuriSizov avatar Jun 01 '23 08:06 YuriSizov

Mhm. On a second thought, it's fine to use a BG overlay for the mouth, as long as its edges don't overlap with blue edges.

MewPurPur avatar Jun 01 '23 10:06 MewPurPur

Superseded by #78015. Thanks for your contribution!

akien-mga avatar Jun 10 '23 10:06 akien-mga