godot icon indicating copy to clipboard operation
godot copied to clipboard

[Scons] Implement module dependency sorting.

Open Faless opened this issue 3 years ago • 1 comments

Modules can now call:

env.module_add_dependencies(name: str, deps: list, optional: bool)

To add required or optional dependencies during the "can_build" step.

Required dependencies will be checked and the module will be not be enabled when they are missing, printing a warning to notify the user.

Closes #53443.

Faless avatar Aug 04 '22 18:08 Faless

Shouldn't we print something when a module is disabled due to a missing dependency?

akien-mga avatar Aug 06 '22 11:08 akien-mga

Shouldn't we print something when a module is disabled due to a missing dependency?

The module_check_dependencies function does that, see https://github.com/godotengine/godot/pull/63919/files#diff-a030241bf0d343232428bf723a03a0a71e8b5dd5ca77b3a852997dd95ab95f41R368 , we can move that to the SConstruct instead

Faless avatar Aug 07 '22 11:08 Faless

Shouldn't we print something when a module is disabled due to a missing dependency?

The module_check_dependencies function does that, see #63919 (files) , we can move that to the SConstruct instead

I guess it's fine as is, that's where you have the info handy on which deps are missing.

akien-mga avatar Aug 07 '22 14:08 akien-mga

Thanks!

akien-mga avatar Aug 07 '22 14:08 akien-mga

This is really useful!

AndreaCatania avatar Aug 19 '22 12:08 AndreaCatania