godot
godot copied to clipboard
[Scons] Implement module dependency sorting.
Modules can now call:
env.module_add_dependencies(name: str, deps: list, optional: bool)
To add required or optional dependencies during the "can_build" step.
Required dependencies will be checked and the module will be not be enabled when they are missing, printing a warning to notify the user.
Closes #53443.
Shouldn't we print something when a module is disabled due to a missing dependency?
Shouldn't we print something when a module is disabled due to a missing dependency?
The module_check_dependencies function does that, see https://github.com/godotengine/godot/pull/63919/files#diff-a030241bf0d343232428bf723a03a0a71e8b5dd5ca77b3a852997dd95ab95f41R368 , we can move that to the SConstruct instead
Shouldn't we print something when a module is disabled due to a missing dependency?
The
module_check_dependenciesfunction does that, see #63919 (files) , we can move that to the SConstruct instead
I guess it's fine as is, that's where you have the info handy on which deps are missing.
Thanks!
This is really useful!