godot icon indicating copy to clipboard operation
godot copied to clipboard

Increase the default Material alpha scissor threshold to 0.5

Open Calinou opened this issue 3 years ago • 5 comments

This matches the glTF specification and the Label3D default. This provides better transparency for distant objects, preventing them from becoming too opaque at a distance.

Calinou avatar Jun 10 '22 08:06 Calinou

Might be worth linking to the relevant part of the glTF spec to document why this value is used (in the constructor)?

akien-mga avatar Jun 10 '22 08:06 akien-mga

Might be worth linking to the relevant part of the glTF spec to document why this value is used (in the constructor)?

Done.

Calinou avatar Jun 10 '22 09:06 Calinou

The problem with 0.5 instead of 0.99 is that when filter is used for something like pixel art in 3D, you will see some extra outline that will generally be unintended.

reduz avatar Aug 06 '22 22:08 reduz

But looking at the current value being 0.05 I have no idea. Would be nice to research why the current value is where it is.

reduz avatar Aug 06 '22 22:08 reduz

is that when filter is used for something like pixel art in 3D

I think there are other problems if you're using filter with pixel art in 3D :slightly_smiling_face:

(Unless you're using a shader like Smooth pixel filtering, of course.)

Calinou avatar Aug 07 '22 05:08 Calinou

Just needs a rebase, the actual change was merged already in your other PR https://github.com/godotengine/godot/pull/54028 which (strangely enough was approved by reduz one week before commenting on this PR

For future reference 3.x uses a default of 0.98, it was changed to 0.05 in https://github.com/godotengine/godot/pull/40364 and no comment was made about why it was changed.

clayjohn avatar Aug 28 '22 23:08 clayjohn

Indeed, I forgot I had made a PR about this last year…

I've rebased this PR to make it work purely as a documentation change.

Calinou avatar Aug 29 '22 12:08 Calinou

Thanks!

akien-mga avatar Aug 30 '22 06:08 akien-mga