Scene tree/FileSystem node renaming issues
Tested versions
- Reproducible: Godot 4.6 dev 6
- Not reproducible: Godot 4.5.1
System information
Godot v4.6.dev6 - Fedora Linux 43 (Workstation Edition) on Wayland - Wayland display driver, Multi-window, 1 monitor - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 (nvidia; 580.105.08) - AMD Ryzen 5 3600XT 6-Core Processor (12 threads) - 15.50 GiB memory
Issue description
After renaming node, when you select different input field, renaming state is not "exited", once you start typing, node name gets changed instead of entering value in recently selected input field.
Edit: I think those issues are happening because focus is not being lost, i have listed all the issues that are caused as a result. Perhaps errors: ERROR: editor/scene/scene_tree_editor.cpp:1651 - Parameter "which" is null. & ERROR: editor/docks/scene_tree_dock.cpp:4163 - Parameter "node" is null. has something to do with that.
Steps to reproduce
- Select node in scene tree
- Start renaming node (double click on name or press F2)
- Select any input field (Filter files, Filter Properties...)
- ⚠️ Observe active cursor appears on 2 places (File that we were renaming and input field we clicked)
- Start typing
- ⚠️ Observe Node's name gets updated instead of input field we selected
https://github.com/user-attachments/assets/6757a88e-235a-4ef7-94bd-1d59c679f347
This is probably also related to this:
- Start renaming node
- Click empty space on scene tree widget
- ⚠️ Observe focus isn't lost from name label
- Click second time on scene tree widget's empty space
- ⚠️ Observe focus is lost but we get following error in output:
ERROR: editor/scene/scene_tree_editor.cpp:1651 - Parameter "which" is null.
- ⚠️ Observe focus is lost but we get following error in output:
https://github.com/user-attachments/assets/a01d566d-5b34-407c-89ea-e30a942f7428
Another related issue:
- Start renaming entry
- Resize widget
- ⚠️ Observe renaming field not changing position and breaking design
https://github.com/user-attachments/assets/b69119de-1597-41f7-8f81-0760adf7194d
Possibly related to:
- https://github.com/godotengine/godot/issues/113476
- https://github.com/godotengine/godot/issues/113332
- https://github.com/godotengine/godot/issues/113669