godot icon indicating copy to clipboard operation
godot copied to clipboard

Change Version Control bottom dock to EditorDock

Open KoBeWi opened this issue 3 weeks ago • 4 comments

Part of #113024

Seems like we have 2 Version Control docks and EditorDock was already being used in that file 🤔 Which unfortunately means that both docks use the same icon, which will be a problem if they will be able to share a slot (right now they can't). Suggestions for new icon welcome, I considered just flipping the existing one.

Also the new dock is global. The plugin adds/removes the dock when necessary and it's always visible, so I guess that's fine. EDIT: Yeah... image

KoBeWi avatar Dec 02 '25 14:12 KoBeWi

What happens when you select the menu option? Can you send your editor_layout.cfg?

KoBeWi avatar Dec 03 '25 00:12 KoBeWi

Well for the record, I can't reproduce this issue. The docks appear fine in my case. Can anyone else reproduce this problem? Is it really caused by this PR?

KoBeWi avatar Dec 04 '25 22:12 KoBeWi

I think the Commit dock should get another icon, probably something like below (just a screenshot), as it represents not a tree but single commit

lodetrick avatar Dec 08 '25 00:12 lodetrick

image

KoBeWi avatar Dec 08 '25 12:12 KoBeWi

Well for the record, I can't reproduce this issue. The docks appear fine in my case. Can anyone else reproduce this problem? Is it really caused by this PR?

I was able to reproduce for a moment but then it was correct, I'm still not sure what happened. It occurred the first time I got the version control plugin to turn on in the repo. I opened Editor --> Editor Docks and click on Commit or Version Control but nothing happens. Weirdly I restarted the editor and the issue went away, so I'm not too sure what that was about. I used the EditorDebugger to look at the tree and it didn't look like either dock was in the tree (not even under the closed_dock_parent)

lodetrick avatar Dec 10 '25 09:12 lodetrick