godot icon indicating copy to clipboard operation
godot copied to clipboard

Implement XFCE support in os_linuxbsd.cpp

Open DSOE1024 opened this issue 3 weeks ago • 10 comments

Added support for XFCE by executing 'exo-open' alongside 'kde-open'.

https://docs.xfce.org/xfce/exo/preferred-applications

DSOE1024 avatar Nov 29 '25 23:11 DSOE1024

@AThousandShips Hello, may I ask if I need to provide more description for this PR? Also, I would like to know which milestone this PR is going to be merged into. Thank you very much!

DSOE1024 avatar Dec 08 '25 06:12 DSOE1024

It will be merged when it's been approved and ready, not scheduled for any specific milestone (hence the 4.x)

AThousandShips avatar Dec 08 '25 10:12 AThousandShips

@bruvzg Thank you for your code review. I have corrected the issues mentioned above.

DSOE1024 avatar Dec 08 '25 12:12 DSOE1024

It will be merged when it's been approved and ready, not scheduled for any specific milestone (hence the 4.x)

Thanks!

DSOE1024 avatar Dec 08 '25 12:12 DSOE1024

Please squash the commits, see The interactive rebase.

OK

DSOE1024 avatar Dec 08 '25 12:12 DSOE1024

You didn't push with git push --force so you created a merge commit, fix this by:

git reset --hard 0462402
git push --force

If you don't need a rebase

Though the commit message should be updated to not contain feature it's not necessary, you can do that by adding git commit --amend between the two commands above

AThousandShips avatar Dec 08 '25 13:12 AThousandShips

I can help if you need help fixing the commits

AThousandShips avatar Dec 08 '25 13:12 AThousandShips

You didn't push with git push --force so you created a merge commit, fix this by:

git reset --hard 0462402
git push --force

If you don't need a rebase

Though the commit message should be updated to not contain feature it's not necessary, you can do that by adding git commit --amend between the two commands above

Thank you, I am trying to modify git commits

DSOE1024 avatar Dec 08 '25 13:12 DSOE1024

Try the following

git reset --hard 0462402
git commit --amend
git push --force

Did that not work correctly?

AThousandShips avatar Dec 08 '25 13:12 AThousandShips

Try the following

git reset --hard 0462402
git commit --amend
git push --force

Did that not work correctly?

Thank you very much, it has worked.

DSOE1024 avatar Dec 08 '25 13:12 DSOE1024

Thanks! Congratulations on your first merged contribution! 🎉

Repiteo avatar Dec 08 '25 18:12 Repiteo