godot icon indicating copy to clipboard operation
godot copied to clipboard

Fix the VRS attachment being incorrectly added to `color_attachments`

Open NetroScript opened this issue 5 months ago • 0 comments
trafficstars

Fixes #107183.

Regression from #99551. @DarioSamo

During the refactoring of the aforementioned PR the VRS attachment index was removed as property of the FramebufferPass struct (it was moved to method parameters). In this process an if-else branch setting this struct value was removed (link). This caused the final branch to execute also for the VRS attachment, which then adds the index to the color_attachments list. This list gets iterated and marks each attachment as already used in this pass, triggering the assertion of the attachment already being used when it should normally be processed for the fragment shading rate (link).

The fix is just reintroducing the (now empty) branch to prevent the VRS attachment texture from being added to color_attachments.

NetroScript avatar Jun 12 '25 11:06 NetroScript