godot icon indicating copy to clipboard operation
godot copied to clipboard

Published 20 hours ago • verified publisher icon godotengine

Move Web export threads options out of variant

Open adamscott opened this issue 5 months ago • 4 comments
trafficstars

This PR moves the newly added (by #104458) variant/emscripten_pool_size and variant/godot_pool_size to threads/emscripten_pool_size and threads/godot_pool_size. It also adds the functionality to make the threads option only appear if threads are enabled. (a future PR will hide more data, i.e. PWA options only if it's enabled)

https://github.com/user-attachments/assets/9f0adb90-f6dc-4a71-90be-8d71c417a858

The issue stems of having 2 options prominently featured only for thread builds. This is bad, as most of Godot exports are expected to be single-threaded.

adamscott avatar Jun 11 '25 22:06 adamscott

Cc. @marcosc90

adamscott avatar Jun 12 '25 12:06 adamscott

Does it make sense to mark any of those as "Advanced Options"?

dsnopek avatar Jun 12 '25 12:06 dsnopek

Does it make sense to mark any of those as "Advanced Options"?

Yeah, they could be both. Hidden when off and marked as advanced.

adamscott avatar Jun 12 '25 13:06 adamscott

IMO if they're hidden by default (threads is off by default), then making them advanced might be too much and make them unintuitive to find. So I would either make them hidden contextually, or make them advanced options.

akien-mga avatar Jun 12 '25 13:06 akien-mga