godot icon indicating copy to clipboard operation
godot copied to clipboard

Implement permission request for Apple embedded platforms, fix microphone input

Open migueldeicaza opened this issue 5 months ago • 6 comments
trafficstars

Fixes https://github.com/godotengine/godot-proposals/issues/12563 but also fixes the "Recording audio on iOS does not work" from 33885.

This now addresses all issues I spotted in https://github.com/godotengine/godot/issues/33885 and I have tested it against the Godot recording sample and it finally works on iOS.

migueldeicaza avatar Jun 06 '25 21:06 migueldeicaza

This pull request now also includes a fix for #33885

migueldeicaza avatar Jun 07 '25 15:06 migueldeicaza

@akien-mga Now that this went from 'necessary enhancement to fix a bug' to 'fixes a five year old bug that has prevented recording from working on iOS', could we change the label from enhancement?

migueldeicaza avatar Jun 07 '25 15:06 migueldeicaza

I wonder how https://github.com/godotengine/godot/pull/106305 has been confirmed to be working by its author, since I expect camera access to also require a permission just like microphone access.

Calinou avatar Jun 09 '25 15:06 Calinou

I wonder how https://github.com/godotengine/godot/pull/106305 has been confirmed to be working by its author

At least on macOS, camera server do auto request permission when feed is activated.

bruvzg avatar Jun 09 '25 15:06 bruvzg

I wonder how #106305 has been confirmed to be working by its author, since I expect camera access to also require a permission just like microphone access.

I've created a test application where I've incorporated CameraTexture into the scene tree. As a result, you'll notice a camera access permission dialog appearing when the app launches.

shiena avatar Jun 09 '25 15:06 shiena

While addressing review comments, please also:

  • Resolve the style issues, which currently prevent the rest of CI from running (https://github.com/godotengine/godot/actions/runs/15509113661/job/43667689824?pr=107233 )
    • We recommend using our pre-commit hook for that: https://docs.godotengine.org/en/latest/contributing/development/code_style_guidelines.html#pre-commit-hook
  • Squash the commits so it's ready to merge as a single commit (or two if you want to split them logically with first implementing permission request support, and then fixing the microphone input using it).

akien-mga avatar Jun 12 '25 14:06 akien-mga

Folks, apologies, but I am away for a month on vacation. Would appreciate if someone takes over this patch.

migueldeicaza avatar Jun 20 '25 03:06 migueldeicaza

Superseded by #107973. Thanks for the contribution!

akien-mga avatar Jun 25 '25 14:06 akien-mga