godot-vscode-plugin icon indicating copy to clipboard operation
godot-vscode-plugin copied to clipboard

Do not support Chinese symbol jump

Open wayrboy opened this issue 1 year ago • 6 comments

Godot version

4.3stable

VS Code version

1.86.1

Godot Tools VS Code extension version

2.1

System information

windows 11

Issue description

621d7d92d919b74ce05bfe105e7339f3

Steps to reproduce

621d7d92d919b74ce05bfe105e7339f3

wayrboy avatar Sep 03 '24 14:09 wayrboy

Do you mean Ctrl + clicking does not work on identifiers that are in Chinese?

Calinou avatar Sep 06 '24 21:09 Calinou

@wayrboy Please at least paste your example code so I can try and reproduce the problem.

DaelonSuzuka avatar Sep 08 '24 03:09 DaelonSuzuka

@Calinou yes

wayrboy avatar Sep 20 '24 03:09 wayrboy

@DaelonSuzuka

extends Label

class 工作类: var 目标次数 = 0

class test: var t = 0

var 工作 = 工作类.new()

var t = test.new()

does not work on identifiers that are in Chinese

wayrboy avatar Sep 20 '24 03:09 wayrboy

@DaelonSuzuka image image

After studying for a while, adding some rules to regular expressions can solve the problem of high grammar, but it still has not solved the problem of fast jump. Please tell me what to do

wayrboy avatar Sep 26 '24 08:09 wayrboy

I cannot fix the fast jump feature because that's provided by the Language Server, which is a part of the Engine.

I'm still thinking about the right way to fix the syntax highlighting, because if I make that change, I will also have to make it in hundreds of other rules, and I won't do that without being certain what the effects will be.

DaelonSuzuka avatar Oct 14 '24 14:10 DaelonSuzuka

This isn't limited to Chinese characters, seems to be a wider issue with characters that aren't used by english.

Here it is failing for Polish letters:

Image

Calandiel avatar Mar 28 '25 10:03 Calandiel

I cannot fix the fast jump feature because that's provided by the Language Server, which is a part of the Engine.

I'm still thinking about the right way to fix the syntax highlighting, because if I make that change, I will also have to make it in hundreds of other rules, and I won't do that without being certain what the effects will be.

Please fix this bug, it is very unfriendly to regions where the official language is not English. Thank you

blmz avatar Apr 02 '25 14:04 blmz

@blmz Please don't bump issues without contributing significant new information. Use the :+1: reaction button on the first post instead.

Calinou avatar Apr 02 '25 15:04 Calinou

See https://github.com/godotengine/godot/pull/105347 for the server part

HolonProduction avatar Apr 13 '25 14:04 HolonProduction