godot-ios-plugins icon indicating copy to clipboard operation
godot-ios-plugins copied to clipboard

Policy for contributing more plugins

Open extrawurst opened this issue 4 years ago • 6 comments

I wrote a plugin now that allows access to iOS native api UIImpactFeedbackGenerator (nicer haptics than regular vibration). I was wondering whether this might be something worth adding to the official plugins repo since it is only giving access to iOS native API and no third party stuff.

if this is welcomed I can make it a PR.

extrawurst avatar Apr 23 '21 11:04 extrawurst

@akien-mga I think we should come up with some way to include new plugins into this repo, but I'm not really sure how to make it work.

naithar avatar Apr 23 '21 11:04 naithar

It's mostly up to you as maintainer, but IMO we can add more first-party plugins here which give access to native iOS APIs, as long as the implementation seems easy enough to maintain. We can also aim to grow the team of maintainers of iOS plugins here to ensure that it's manageable.

Plugins for third-party APIs should likely stay separate and distributed via community repositories.

akien-mga avatar Apr 23 '21 15:04 akien-mga

btw. I put the plugin now in a GitHub repo, we can migrate it whenever we want: https://github.com/extrawurst/godot-ios-impact-plugin

extrawurst avatar Apr 23 '21 21:04 extrawurst

@akien-mga got it, thanks :)

@extrawurst I'll wait for your PR then. And don't forget to modify SConstruct and release scripts to support new plugin.

naithar avatar Apr 24 '21 10:04 naithar

@naithar I have a question though, where do I need to add documentation for whatever api I am adding? can't find that in here.

extrawurst avatar Apr 24 '21 12:04 extrawurst

For now every plugin has it's own README file with description and API, ex: https://github.com/godotengine/godot-ios-plugins/blob/master/plugins/apn/README.md. But if you have any idea how to make it work better, I'm open to suggestions.

naithar avatar Apr 24 '21 15:04 naithar