godot-git-plugin icon indicating copy to clipboard operation
godot-git-plugin copied to clipboard

SSH Authentication is always failing

Open Brandon-M-Hartman opened this issue 3 years ago • 16 comments

Brandon-M-Hartman avatar Jan 14 '22 15:01 Brandon-M-Hartman

I am not able to reproduce this error on my Windows 10, with Godot 3.5 beta1 and plugin v2.0.0.

I tried looking more on this specific error and it seems it is sometimes fixed by:

twaritwaikar avatar Jan 14 '22 18:01 twaritwaikar

Found that same thread earlier, haha. Didn't work there either. I also saw issues around generating the key with Powershell terminal vs Command Prompt - tried both, same issue.

I'll just remove the plugin and use VSCode and will try the plugin again in later versions

Brandon-M-Hartman avatar Jan 14 '22 18:01 Brandon-M-Hartman

@Huckler Hope you find this plugin useful later on.

As for now, I would prefer to keep this issue open so that it is visible to newcomers and me as a reminder that this was a problem. You may use the unsubscribe button at the top right to stop receiving notifications/emails from the conversations under this thread.

twaritwaikar avatar Jan 14 '22 18:01 twaritwaikar

I'm having the same problem, maybe I didn't set it up correctly a project in github, maybe you could make a training video in which you would explain to beginners how to work with it correctly.

InkRobert avatar Jan 15 '22 06:01 InkRobert

A training video would be nice, but it has the risk of containing outdated information later on because the workflow may change later on. Instead of that, I created a wiki page to set up the network features of this plugin at - https://github.com/godotengine/godot-git-plugin/wiki/Git-plugin-v2#faqs

twaritwaikar avatar Jan 15 '22 10:01 twaritwaikar

Possibly, but I'm still getting this error, and maybe I didn't properly set up the project in git, any notes?

InkRobert avatar Jan 15 '22 11:01 InkRobert

@InkRobert Could you check if your .ssh folder has the right permissions? In Windows, you might be able to solve this by running Godot with admin rights. On Linux, you may check the permissions by running ls -la ~/.ssh

twaritwaikar avatar Jan 15 '22 11:01 twaritwaikar

I created a new project and everything works. But on my main project, which was created on 3.2, an error appears godot-git-plugin\src\git_api.cpp:586 - GitAPI: Failed to push. Error -1: failed to write chunk header: ￐ᄀ￐ᄉ￑タ￐ᄇ￐ᄉ￑タ ￐ᄇ￐ᄉ￑タ￐ᄑ￑テ￐ᄏ ￐ᄑ￐ᄉ￐ᄡ￐ᄒ￐﾿￑テ￑チ￑ツ￐ᄌ￐ᄐ￑ヒ￐ᄍ ￐ᄌ￐ᄏ￐ᄌ ￐ᄑ￐ᄉ￑タ￐ᄚ￑チ￐﾿￐ᄒ￐ᄋ￐ᄑ￐ᄚ￐ᄑ￐ᄑ￑ヒ￐ᄍ ￐ᄒ￑ツ￐ᄇ￐ᄉ￑ツ :

InkRobert avatar Jan 15 '22 18:01 InkRobert

@InkRobert The push/pull/fetch features that exist in the v2 of this plugin only work with Godot 3.5 beta right now. For Godot 3.2 to 3.4, you need to use the v1, which unfortunately has a very limited feature set.

twaritwaikar avatar Jan 15 '22 18:01 twaritwaikar

Also, is the SSH authentication now working in your new project?

twaritwaikar avatar Jan 15 '22 18:01 twaritwaikar

Yes, I'm using PEM on a project and it works on a new project, but the main project was created on 3.2, but I ran it on 3.5 beta 1, and it doesn't work!

InkRobert avatar Jan 15 '22 18:01 InkRobert

That looks like a separate issue then. Could you please open a new issue for it?

twaritwaikar avatar Jan 15 '22 19:01 twaritwaikar

For reference, the new issue opened by @InkRobert is https://github.com/godotengine/godot-git-plugin/issues/102.

Calinou avatar Jan 15 '22 19:01 Calinou

FWIW, I get this error when I open the editor up and try to fetch/push/pull without remembering to open the settings and put in the passphrase for my SSH key again. Adding the passphrase and trying again resolves the issue.

It would be nice if the plugin was able to use the credential helper set in my .gitconfig file:

[credential "https://github.com"]
    helper = !/opt/homebrew/bin/gh auth git-credential

naim avatar Aug 11 '22 21:08 naim

Yes, the editor should technically reach into the keychain or the cred helper to retrieve that. However, there needs to be some more discussion on this because any new changes we do, we also need to ensure we don't put barriers to implementing this proposal - https://github.com/godotengine/godot-proposals/issues/4369.

I am planning to implement it for Godot 4.0 after this plugin is ported to GDExtension

twaritwaikar avatar Aug 11 '22 22:08 twaritwaikar

Sounds good. Thanks for the comment!

naim avatar Aug 11 '22 23:08 naim