godot-git-plugin icon indicating copy to clipboard operation
godot-git-plugin copied to clipboard

Build for macOS 10.12+ (Same as Godot)

Open daviewales opened this issue 3 years ago • 3 comments

The pre-built binaries appear to be built for macOS 11+ However, Godot itself appears to support macOS 10.12+.

Would it be possible to tweak the GitHub actions to use the same magic that's used to target 10.12 in the Godot builds?

I can't quite figure out what the magic is, but I'm wondering if it's one of these:

https://github.com/godotengine/godot/blob/b3bd08207032ca146319f4b25654bcddd31ee401/platform/macos/detect.py#L117 https://github.com/godotengine/godot/blob/b3bd08207032ca146319f4b25654bcddd31ee401/misc/dist/macos_template.app/Contents/Info.plist#L39 https://github.com/godotengine/godot/blob/b3bd08207032ca146319f4b25654bcddd31ee401/misc/dist/macos_tools.app/Contents/Info.plist#L42

daviewales avatar Aug 07 '22 11:08 daviewales

The macOS binaries have been built using this Github workflow - https://github.com/godotengine/godot-git-plugin/blob/master/.github/workflows/build.yml

I wonder if I can just change the macos-11 to macos-10.15, but it looks like they have been deprecated by Github

twaritwaikar avatar Aug 07 '22 12:08 twaritwaikar

Also, should probably try to get some attention to https://github.com/godotengine/godot-git-plugin/issues/59 while we are at it

twaritwaikar avatar Aug 07 '22 12:08 twaritwaikar

Changing macos-11 to macos-10.15 didn't work because of an error in our snapshot of godot-cpp - https://github.com/godotengine/godot-git-plugin/runs/7712698049?check_suite_focus=true

I also see that godot-cpp also uses macos-11 in its CI builds, so a better way to find how it can be done is to look into how godot-cpp (3.5) is getting compiled.

twaritwaikar avatar Aug 07 '22 12:08 twaritwaikar

This will be fixed in the next v2.x release

twaritwaikar avatar Aug 09 '22 08:08 twaritwaikar