godot-docs
godot-docs copied to clipboard
Replace "alt" with "opt" for macOS shortcuts
In the past Mac keyboards would have "alt" written on the option key in addition to "option", these days it's just "option". I'm using "Opt" instead of "Option" for these based on discussions with bruvzg in rocket chat. Closes #7959.
As a Mac user, I agree with this PR. The key is labeled as "option" on my keyboard.
I couldn't find any references to a macOS Alt
that weren't included in this PR.
If accepted, should this line in the Docs Writing Guidelines also be changed along to "On macOS, Cmd
often replaces Ctrl
in keyboard shortcuts and Opt
replaces Alt
in keyboard shortcuts." ?
https://github.com/godotengine/godot-docs/blob/ec3426d869ef09fe10e159563a208c6d7fe3352f/contributing/documentation/docs_writing_guidelines.rst?plain=1#L499-L500
I couldn't find any references to a macOS
Alt
that weren't included in this PR.If accepted, should this line in the Docs Writing Guidelines also be changed along to "On macOS,
Cmd
often replacesCtrl
in keyboard shortcuts andOpt
replacesAlt
in keyboard shortcuts." ?https://github.com/godotengine/godot-docs/blob/ec3426d869ef09fe10e159563a208c6d7fe3352f/contributing/documentation/docs_writing_guidelines.rst?plain=1#L499-L500
I think it would make more sense to just link to the shortcut page from there.
I've updated this PR so the doc writing guidelines just link to the keyboard shortcut page.
@skyace65 thanks for pointing this out and I see that we both ran into the same confusion! My only recommendation is to reorder the mac keys based on the order of the keyboard, so instead of Cmd + Opt
, it's Opt + Cmd
since this is what the physical order of the keys are, how a user would press the keys in order, and also how the menus order the shortcut.
Indeed, Apple seems to list Opt first: https://support.apple.com/en-us/HT201236
Indeed, Apple seems to list Opt first: https://support.apple.com/en-us/HT201236
Fixed.
I'm interested in testing this, but can you rebase?
My mac keyboard is:
I'm interested in testing this, but can you rebase?
My mac keyboard is:
Rebased.
Merged! Thanks you.
Cherry-picked to 4.2 in https://github.com/godotengine/godot-docs/pull/9648.