godot-docs
godot-docs copied to clipboard
Updating change_scene and change_scene_to
Closes #6156
Quick search for change_scene shows a few more uses across the doc. More changes needed in the following files :
https://github.com/godotengine/godot-docs/blob/9cc34c72de2da2376ee708c2e49a5d9dbbd32b16/tutorials/scripting/singletons_autoload.rst#L118
https://github.com/godotengine/godot-docs/blob/becad70a96dba6e18edd030836a5cf82abb1df4d/tutorials/best_practices/autoloads_versus_internal_nodes.rst#L9
https://github.com/godotengine/godot-docs/blob/3e00267dc1869d1fccab0501a23b982ab7801662/tutorials/scripting/change_scenes_manually.rst#L45
https://github.com/godotengine/godot-docs/blob/0e68dcff89a5d55beb7d3681a98dc4fdba5ff5d0/tutorials/best_practices/scene_organization.rst#L297
You also have a typo in your commit message, which is worth fixing when you'll be rebasing this PR after applying the suggested changes and fixes.
ah damn didnt see that, will fix
ok sorry for not being the smartest (im very new to github and all that) i made the changes on my repo, how do i add them to this pr? i also made the changes directly on the browser editor so i think that doesnt help at all.
ok sorry for not being the smartest (im very new to github and all that) i made the changes on my repo, how do i add them to this pr? i also made the changes directly on the browser editor so i think that doesnt help at all.
If you make changes to the same branch, they will just appear here. If you've made a new branch, then this won't work. You also can't rebase or squash using the GitHub's web UI and need to use a desktop client for Git to do that.
ah, okay, imma make the changes on the right branch
ok changes made
i think that should be all but i'll check
I found two more places that need to be updated:
$ git grep -P 'change_scene(?!_to_(file|packed))'
[…]
tutorials/scripting/singletons_autoload.rst: # Optionally, to make it compatible with the SceneTree.change_scene() API.
tutorials/scripting/singletons_autoload.rst: // Optionally, to make it compatible with the SceneTree.change_scene() API.
Thanks and congrats on your first merged PR to Godot Engine's documentation! And thanks for everyone helping to point out things :)
Thanks and congrats on your first merged PR to Godot Engine's documentation! And thanks for everyone helping to point out things :)
Thanks!