godot-docs icon indicating copy to clipboard operation
godot-docs copied to clipboard

5373 - Step by step instancing example in zip file updated to new annotation style

Open ueco-jb opened this issue 3 years ago • 4 comments

closes https://github.com/godotengine/godot-docs/issues/5373

It changes line in: getting_started/step_by_step/files/instanting.zip/Main.gd

- export (PackedScene) var Ball
+ @export var Ball: PackedScene

ueco-jb avatar Nov 07 '21 10:11 ueco-jb

I think we should remove this ZIP file and point to the demo project in https://github.com/godotengine/godot-demo-projects instead. This would avoid storing ZIP files within the documentation, which should be avoided for various reasons.

Calinou avatar Nov 07 '21 15:11 Calinou

@Calinou I agree in general. Although in godot-demo-projects there is a similar instacing project: Instancing Demo Should:

  • this step by step instansing page reflect (in code snippets, for example) already existing example,
  • Instancing Demo be replaced by content of this instanting.zip
  • new directory in godot-demo-projects be created, which would point to all .zip files from getting_started?

I'd prefer 3rd option, because first option is kind of more complicated then instancing.zip, and it'd be a shame to just remove Instancing Demo as well.

ueco-jb avatar Nov 07 '21 15:11 ueco-jb

@Calinou ?

ueco-jb avatar Nov 12 '21 12:11 ueco-jb

@ueco-jb Since demos haven't been updated for Godot 4.0 yet, I would prefer we wait for 4.0 to be more stable to start upgrading all demos to Godot 4.0. Then we can look at updating the current instancing tutorial to reflect the demo's contents.

4.0.dev is not production-ready and therefore not recommended for beginners, so it's not a critical issue if beginner tutorials aren't updated yet. It will be done in due time :slightly_smiling_face:

Calinou avatar Nov 12 '21 15:11 Calinou

Superseded by #7222

skyace65 avatar Apr 28 '23 00:04 skyace65