godot-docs icon indicating copy to clipboard operation
godot-docs copied to clipboard

Published 20 hours ago • verified publisher icon godotengine

add pseudolocalization tutorial [WIP]

Open angad-k opened this issue 3 years ago • 5 comments

Tutorial PR for the pseudolocalization feature I'm adding to Godot as part of GSoC.

angad-k avatar Jul 28 '21 14:07 angad-k

Looks good! :)

There is a build error with a wrong label to fix, and also the indentation at the very last line seems incorrect.

mhilbrunner avatar Aug 10 '21 12:08 mhilbrunner

Now that this has landed with https://github.com/godotengine/godot/pull/51395, whats the state of this docs PR? :)

mhilbrunner avatar Sep 09 '21 11:09 mhilbrunner

Other than the failing check, this is pretty much done. Any idea why the check is failing? The label is correct according to me. This is the property that the label's referring to.

angad-k avatar Sep 09 '21 11:09 angad-k

Probably because the class docs weren't synced for master for some time, so the new properties/methods aren't available yet. We'll have to wait for Akien to get back from vacation and sync it eventually :)

mhilbrunner avatar Sep 10 '21 10:09 mhilbrunner

Let it be a draft until we can actually consider merging it.

YuriSizov avatar Sep 15 '21 16:09 YuriSizov

This probably needs a force push to correctly rerun the CI

YuriSizov avatar Jan 13 '23 13:01 YuriSizov

Okay! I'll do it by tonight.

angad-k avatar Jan 13 '23 13:01 angad-k

Force push's done, ig it shall require an approval for the workflow to rerun from a maintainer.

angad-k avatar Jan 16 '23 11:01 angad-k

@Calinou @mhilbrunner would you like to review this again or is it good to go? I know the image should be webp but I'm willing to overlook it since this PR predates that standard and it's just 1 image.

skyace65 avatar Jan 26 '23 02:01 skyace65

Hey, made the requested changes - sorry for the massive delay- had looked at the review and then it slipped out of my mind until now. 😅

angad-k avatar Feb 23 '23 16:02 angad-k