godot-docs icon indicating copy to clipboard operation
godot-docs copied to clipboard

AnimationTree documentation simplification and expansion

Open saabdo42 opened this issue 1 year ago • 5 comments

Simplified AnimationTree language, added documentation for Advance Expression, made images webp and colorblind friendly with more descriptive names.

Fixes: https://github.com/godotengine/godot-docs/issues/9699 Fixes: https://github.com/godotengine/godot-docs/issues/7753 Fixes: https://github.com/godotengine/godot-docs/issues/7658

saabdo42 avatar Oct 11 '24 16:10 saabdo42

Is there a good way to preview doc changes?

fire avatar Oct 11 '24 17:10 fire

Not familiar with spinx errors.

Warning, treated as error:
/home/runner/work/godot-docs/godot-docs/tutorials/animation/animation_tree.rst:19:Title underline too short.

AnimationTree and AnimationPlayer
-------------------------
make: *** [Makefile:37: dummy] Error 2

fire avatar Oct 11 '24 19:10 fire

Ok just fixed that error

saabdo42 avatar Oct 12 '24 02:10 saabdo42

I'm not sure how to assign issues to pull requests, but this fixes #9699 and #7753

saabdo42 avatar Oct 12 '24 14:10 saabdo42

Add this to your first post.

Fixes: https://github.com/godotengine/godot-docs/issues/9699
Fixes: https://github.com/godotengine/godot-docs/issues/7753

fire avatar Oct 12 '24 17:10 fire

This PR needs to be rebased.

skyace65 avatar Oct 29 '24 00:10 skyace65

What does that mean? (sorry lol)

saabdo42 avatar Oct 29 '24 02:10 saabdo42

Let me know if you have any questions after reading this. https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html

fire avatar Oct 31 '24 18:10 fire

Any update on this?

saabdo42 avatar Mar 19 '25 23:03 saabdo42

Still need to review this, apologies for the long wait

skyace65 avatar Mar 26 '25 16:03 skyace65

I'll put a bookmark that someone from the animation team needs to look at this.

fire avatar Mar 31 '25 18:03 fire

Merging this as is due to the lack of a response from the animation team.

@saabdo42 Thanks! Apologies on how long this took, congrats on your first merged PR!

skyace65 avatar Jun 08 '25 17:06 skyace65