godot-blender-exporter icon indicating copy to clipboard operation
godot-blender-exporter copied to clipboard

Update for Blender 2.90.1, Add Github Action

Open Williangalvani opened this issue 4 years ago • 2 comments

From visual inspection, the updated scenes are ok. I could use help with fixing install_blender.sh. Do we care about 2.80 and 2.81 in master?

fix #363 fix #372

Ci state can be checked in my fork.

TODO:

  • [ ] Fix install_blender.sh
  • [ ] Enable cache in Actions
  • [x] Change action to run on PRs

Hah! I was sure this would break Travis... Oh well :man_shrugging:

Williangalvani avatar Oct 21 '20 02:10 Williangalvani

I was playing around with a version of install_blender.sh that could work with Blender 3.0 (based on some changes I made here: #411). It looked roughly similar to your version, however, I am thinking it would probably be beneficial to be able to utilize the version argument to choose which URL it should pull.

My first thought is that maybe just hard-coding a bunch of version URLs would be ok for now. Thoughts?

Note: additionally, it would be great if the Docker build could utilize the version number as an argument to make it easier to test different versions quickly. Something like the following:

ARG BLENDER_VERSION=2.81
ENV BLENDER_VERSION=${BLENDER_VERSION}

RUN env | grep BLENDER
$ docker build -t exporter:test .
...
Step 4/4 : RUN env | grep BLENDER
 ---> Running in ba8bdf34ca5f
BLENDER_VERSION=2.81
...
$ docker build --build-arg BLENDER_VERSION=2.91 -t exporter:test .
...
Step 4/4 : RUN env | grep BLENDER
 ---> Running in e83b6425efcf
BLENDER_VERSION=2.91
...

timjklein36 avatar Dec 23 '21 19:12 timjklein36

Is there interest in pulling this to Blender 4.0? I was thinking it might be worthy. Looking for support.

fire avatar Dec 19 '23 22:12 fire