godot-asset-library icon indicating copy to clipboard operation
godot-asset-library copied to clipboard

Published 20 hours ago • verified publisher icon godotengine

Moderation: empty edits allowed or buggy diff?

Open akien-mga opened this issue 7 years ago • 4 comments

See https://godotengine.org/asset-library/asset/edit/77

There is no diff to review for this edit, so either empty edits are not discarded, or there were actual changes but the diff does not show them properly.

akien-mga avatar Sep 11 '16 21:09 akien-mga

@akien-mga yep, empty edits are allowed, and do completely nothing.

That being said, checking for them through code is not that easy, as it has to consider the previews as well.

bojidar-bg avatar Sep 12 '16 06:09 bojidar-bg

so.... I put the address of youtube video and thumbnail. Just changing the dropdown to select Video instead Image. And saved.

marcosbitetti avatar Sep 12 '16 21:09 marcosbitetti

@akien-mga Ah, just saw a use for them -- if we allow putting things like master for the version commit to be downloaded, making an empty edit is the only way to have the hash updated...

bojidar-bg avatar Sep 15 '16 07:09 bojidar-bg

Yeah, but as per #63, we don't want to allow that anymore, used should provided a commit hash or tag so that we know it won't change (tags may change, but then the asset devs are on their own, since the sha256sum will be broken).

@marcosbitetti's comment hints that there might be an issue with videos submission though (may be related to #56).

akien-mga avatar Sep 15 '16 07:09 akien-mga