line 36 has been changed in https://github.com/godong9/solr-node/pull…

Open gyula-s opened this issue 5 years ago • 1 comments

in pr https://github.com/godong9/solr-node/pull/84 the line 36 of the index.d.ts has been changed to suggestQuery(params: SuggestQueryParams | string): this; however the interface itself on line 125 wasn't changed.

This causes transpile errors in my ts project.

this pr rectifies this, and hopefully this will allow us to use the package in the future, and we won't have to keep a forked version of this in our dependencies.

Jun 04 '20 14:06 gyula-s

This issue was added in PR #83 (see also comment on the commit). #84, referenced above as the cause, is actually a solution PR that the present PR (#92) exactly duplicates. For others who encounter this, pinning to 1.1.3 seems to be an OK interim solution if you aren't using the search suggestions or basic Auth provided in 1.2. Long-term, changing to a maintained package is better.

Nov 30 '22 15:11 wbt