react-native-recyclerview-list icon indicating copy to clipboard operation
react-native-recyclerview-list copied to clipboard

Avoid SDK warnings.

Open arendjr opened this issue 7 years ago • 3 comments

This PR simply removes some warnings when using this library in another project.

The buildToolsVersion "23.0.1" should be specified by the host project, and triggers warnings when a library specifies a version that's below the project's version. For completeness, this is the warning I got:

The specified Android SDK Build Tools version (23.0.1) is ignored, as it is below the minimum supported version (27.0.3) for Android Gradle Plugin 3.1.3.
Android SDK Build Tools 27.0.3 will be used.
To suppress this warning, remove "buildToolsVersion '23.0.1'" from your build.gradle file, as each version of the Android Gradle Plugin now has a default version of the build tools.

The compile directives I replaced with implementation since the former is deprecated:

Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html

arendjr avatar Aug 08 '18 09:08 arendjr

Btw, I'm having some trouble verifying things in the example app, because building it fails with the following error:

* What went wrong:
A problem occurred configuring root project 'example'.
> Cannot read packageName from /home/arendjr/Projects/react-native-recyclerview-list/example/android/src/main/AndroidManifest.xml

Now I can see the path to the manifest is wrong (it is missing the app subdir where it actually resides) but I cannot find how to resolve this. Maybe it is due to having a different React Native version installed?

Anyway, I suspect for the example app to work with this PR, you may need to re-add the buildToolsVersion in example/android/build.gradle, like this:

apply plugin: 'com.android.library'

android {
    compileSdkVersion 23
    buildToolsVersion "23.0.1"
}

But I cannot fully verify it...

arendjr avatar Aug 08 '18 09:08 arendjr

Any chance we can get this merged? I'm also running into this issue in a project.

mikeygee avatar Oct 23 '18 00:10 mikeygee

@mikeygee just a few days more and then I'll merge it - quite busy recently. Thanks for your patience

godness84 avatar Oct 25 '18 11:10 godness84