react-native-recyclerview-list icon indicating copy to clipboard operation
react-native-recyclerview-list copied to clipboard

Published 20 hours ago • verified publisher icon godness84

Upgrade RN to 0.55.3 and React to 16.3.1

Open hypest opened this issue 6 years ago • 4 comments

This PR upgrades the React Native version to v0.55.3 (the latest public release at the time of writing) and React to v16.3.1.

The upgrade was performed via react-native-git-upgrade.

hypest avatar Apr 25 '18 21:04 hypest

Hmm, I'd assume that a bump of the package version could be in order. 👋 @godness84 , do you perhaps have a recommendation about which version number to bump to? 0.4.0 perhaps?

hypest avatar Apr 26 '18 07:04 hypest

Thanks @hypest! Can you explain why it's needed to upgrade RN and React? It should work with earlier versions of RN and React even if it was written for an older version of RN. Usually I upgrade it only if newer versions break something (e.g. the native API of RN was changed).

godness84 avatar Apr 27 '18 09:04 godness84

Hey @godness84 , thanks for having a look!

A few days ago, working on having the latest RN version in the project I'm currently working on (the mobile version of the WordPress Gutenberg editor) I ran into some issues that would indicate that react-native-recyclerview-list would need to be upgraded too. I can't remember the exact issues but I remember those went away when I matched react-native-recyclerview-list's versions instead of the latest RN. At that point, and to verify the assumption, I went ahead and did the react-native-recyclerview-list upgrade, at which point I thought it would perhaps be useful to share a PR.

Since then, I found different problems and after fixing them it became apparent that the versions in react-native-recyclerview-list are not problematic. I left the PR open in case it is still useful.

Thanks for sharing your policy on when to upgrade RN. Under this light and the fact that I can't pinpoint some problem with the currently published module, I'd leave it up to you to decide what to do with this PR. Feel free to close or let me know if you have something else in mind. Thanks!

hypest avatar Apr 27 '18 11:04 hypest

Some extra info, I'm getting:

warning " > [email protected]" has incorrect peer dependency "react@^16.3.0-alpha.1".
warning " > [email protected]" has incorrect peer dependency "react-native@^0.54.2".

on yarn install in our RN version-upgraded project. Would that warning be an actual issue, perhaps later, unless the lib's versions are upgraded too?

hypest avatar May 03 '18 08:05 hypest