Alex Kremer
Alex Kremer
@Bronek, please take a look. This may be something that could be improved on `rippled` side.
@mDuo13 can you take a look and advise how you would like to document this if at all. Currently we don't see specific error message documentation for this (or other)...
Is this still a thing @cjcobb23 ? i think we are using boost.json everywhere we can atm.? I'm closing this for now. Reopen if you think this issue still stands.
Ok, let's reopen then.
It might be easier for us to adopt `rippled` JSON library than to do it the other way around. We will talk to `rippled` engineers about this in the future...
Tried to use `clang-analyzer-core` and `clang-analyzer-cplusplus` (in particular [core.NullDereference](https://clang.llvm.org/docs/analyzer/checkers.html#id41)). Unfortunately it does not seem to catch the cases we want even with this option disabled as suggested in the above...
This may be useful in the future. Leaving it for now. See doc here https://xrpl.org/can_delete.html#can_delete
Whether this makes into 2.1 will depend on `rippled` implement the same logic first. CTID support in `tx` is already added.
This is a potential improvement that might come with some side-effects however. Rippled might close the websocket if it's open for long and unused. We need to measure if this...
We can add "closed" but that would change our existing API. I'm not sure there is another way though.